wphyojpl commented on code in PR #3:
URL:
https://github.com/apache/incubator-sdap-in-situ-data-services/pull/3#discussion_r887309479
##########
k8s_spark/parquet.spark.helm/values.yaml:
##########
@@ -110,8 +120,19 @@ affinity: {}
# initialDelaySeconds: 5
bitnami-spark:
+ enabled: true
image:
tag: 3.2.0-debian-10-r44
+ master:
Review Comment:
When I have `master` with no properties ( all are commented out), it
complains. Once I comment it or add some properties with the same default
values from https://github.com/bitnami/charts/tree/master/bitnami/spark, it
works.
##########
k8s_spark/parquet.spark.helm/templates/deployment.yaml:
##########
@@ -57,8 +57,10 @@ spec:
{{- end }}
- name: parquet_file_name
value: {{ .Values.flask_env.parquet_file_name }}
+ {{- if ( index .Values "bitnami-spark" "enabled" ) }}
- name: master_spark_url
- value: {{ .Values.flask_env.master_spark_url }}
+ value: spark://{{ .Release.Name }}-bitnami-spark-master-0.{{
.Release.Name }}-bitnami-spark-headless:7077
Review Comment:
This is the existing value:
```
spark://custom-spark-master-0.custom-spark-headless.bitnami-spark.svc.cluster.local:7077
```
Do we need to add the missing `bitnami-spark.svc.cluster.local`? Most likely
we won't' need it, but I haven't actually tested it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
