briansaildrone commented on code in PR #3:
URL: 
https://github.com/apache/incubator-sdap-in-situ-data-services/pull/3#discussion_r891543369


##########
k8s_spark/parquet.spark.helm/values.yaml:
##########
@@ -110,8 +120,19 @@ affinity: {}
 #   initialDelaySeconds: 5
 
 bitnami-spark:
+  enabled: true
   image:
     tag: 3.2.0-debian-10-r44
+  master:

Review Comment:
   I actually bumped into this this week with a different helm chart.  It 
appears to be a bug with the either bitnami Helm chart or Helm itself expecting 
there to be child keys/values where a parent exists.  If you omit the parent 
altogether ("master" in this case) or retain a comment, things appear to render 
normally.
   
   Not sure there can be further action on this issue since it appears to be 
upstream.  Hopefully future versions of either Helm or Bitnami Spark will 
resolve this.



##########
k8s_spark/parquet.spark.helm/values.yaml:
##########
@@ -110,8 +120,19 @@ affinity: {}
 #   initialDelaySeconds: 5
 
 bitnami-spark:
+  enabled: true
   image:
     tag: 3.2.0-debian-10-r44
+  master:

Review Comment:
   I actually bumped into this this week with a different helm chart.  It 
appears to be a bug with either the bitnami Helm chart or Helm itself expecting 
there to be child keys/values where a parent exists.  If you omit the parent 
altogether ("master" in this case) or retain a comment, things appear to render 
normally.
   
   Not sure there can be further action on this issue since it appears to be 
upstream.  Hopefully future versions of either Helm or Bitnami Spark will 
resolve this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to