+1. LGTM -- Best Regards
------------ Liugddx [email protected] Jia Fan <[email protected]> 于2025年8月6日周三 17:43写道： > Thanks wangxiaogang for your contribute! > +1 for new repo. > > wangxiaogang <[email protected]> 于2025年8月6日周三 17:27写道： > > > > After previous discussions and designs, I implemented a version of the > > X2Seatunnel tool. > > > > https://github.com/apache/seatunnel/issues/9507 > > https://github.com/apache/seatunnel/pull/9664 > > > > We need to first discuss the necessity of adding a new repo. Is it > > better to integrate it into the Seatunnel project or create a separate > > project? > > > > 1. If a new repo is added, it will be inconvenient for me to reuse the > > current code management solution. Also, there may be a lot of work in > > building a new project, and I don't have much experience in this > > regard. > > 2. Previously, using Java to implement it was considered to reuse the > > technical stack of the current Seatunnel project. If it is a new > > project, can Python be considered? Both have their advantages and > > disadvantages, but Python has fewer overall lines of code and better > > support for engines like Jinja2. > > 3. If it is a separate project, the functionality of X2Seatunnel seems > > a bit thin, and I'm worried that the project value may not be > > sufficient. > > > > Of course, the advantages of a separate project are obvious. It can be > > iterated faster and is easier to control. >
