nirnir93 opened a new pull request #482:
URL: https://github.com/apache/incubator-sedona/pull/482
## Is this PR related to a proposed Issue?
#435 #233
## What changes were proposed in this PR?
Deprecating JTS+ in favor of using JTS as a dependency with wrappers
Updating JTS and GeoTools to latest available versions
## How was this patch tested?
Using the existing tests
## Did this PR include necessary documentation updates?
As far as we could tell, there are none. the changes are internal
## Notes
This is a WIP as there seems to be 2 problems in **python** tests:
1. When projecting a spatial RDD and then calculating it's extent, we get
some different results (within 10E-7 of the original test's envelope). We had
trouble projecting the envelope manually and so we don't know if this is a more
or less accurate result. As far as we could tell, this is caused by the usage
of a newer version geotools (23 VS 17)
This effects the following tests:
-
tests/spatial_rdd/test_linestring_rdd.py::TestLineStringRDD::test_constructor
- tests/spatial_rdd/test_point_rdd.py::TestPointRDD::test_constructor
- tests/spatial_rdd/test_polygon_rdd.py::TestPolygonRDD::test_constructor
2. In the following tests, the spatial join returns 100 features instead of
the expected 200:
-
tests/spatial_operator/test_join_query_correctness.py::TestJoinQueryCorrectness::test_inside_point_join_correctness
-
tests/spatial_operator/test_join_query_correctness.py::TestJoinQueryCorrectness::test_on_boundary_point_join_correctness
-
tests/spatial_operator/test_join_query_correctness.py::TestJoinQueryCorrectness::test_inside_linestring_join_correctness
-
tests/spatial_operator/test_join_query_correctness.py::TestJoinQueryCorrectness::test_overlapped_linestring_join_correctness
-
tests/spatial_operator/test_join_query_correctness.py::TestJoinQueryCorrectness::test_inside_polygon_join_correctness
-
tests/spatial_operator/test_join_query_correctness.py::TestJoinQueryCorrectness::test_overlapped_polygon_join_correctness
Note that for some reason, these tests only fail in python and not in
java/scala
We are still working on these issues, and would love if someone has any
experience dealing with the mentions tests (@Imbruced )
We decided to open the PR now so that you could approve the design -
specifically the wrappers implementation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
