Imbruced commented on pull request #482:
URL: https://github.com/apache/incubator-sedona/pull/482#issuecomment-689139826
@nirnir93 I added comments, one file had changes so I added comment within.
For 3 python files I can not find appropriate place so I put changes on top of
Pr changed files with file names. There were two reasons why all tests did not
pass.
- First - Wrong classes used, you used jts geoms which did not compare
userdata within equals method
- Second - Numerical issue, I did not spot any issue within the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]