----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34082/#review126548 -----------------------------------------------------------
sentry-policy/sentry-policy-common/src/main/java/org/apache/sentry/policy/common/PolicyEngine.java (line 55) <https://reviews.apache.org/r/34082/#comment189568> I'm agreed with for Jerry's comments Thank Colin for your patch, I think we should keep the method name with `getAllPrivileges` without `UG` - Dapeng Sun On 五月 12, 2015, 3:01 p.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34082/ > ----------------------------------------------------------- > > (Updated 五月 12, 2015, 3:01 p.m.) > > > Review request for sentry, Dapeng Sun, shen guoquan, and Prasad Mujumdar. > > > Repository: sentry > > > Description > ------- > > Update policy engine for grant user to role > > > Diffs > ----- > > > sentry-policy/sentry-policy-common/src/main/java/org/apache/sentry/policy/common/PolicyEngine.java > 38a5b65 > > sentry-policy/sentry-policy-db/src/main/java/org/apache/sentry/policy/db/SimpleDBPolicyEngine.java > a03794e > > sentry-policy/sentry-policy-indexer/src/main/java/org/apache/sentry/policy/indexer/SimpleIndexerPolicyEngine.java > 2f4bc1d > > sentry-policy/sentry-policy-search/src/main/java/org/apache/sentry/policy/search/SimpleSearchPolicyEngine.java > bc518fb > > sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SimpleSqoopPolicyEngine.java > e8615a0 > > Diff: https://reviews.apache.org/r/34082/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
