----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34082/#review127552 -----------------------------------------------------------
sentry-policy/sentry-policy-db/src/main/java/org/apache/sentry/policy/db/SimpleDBPolicyEngine.java (line 95) <https://reviews.apache.org/r/34082/#comment190911> Should we format the debug log as Getting permissions for groups: {}, users: {}" sentry-policy/sentry-policy-indexer/src/main/java/org/apache/sentry/policy/indexer/SimpleIndexerPolicyEngine.java (line 95) <https://reviews.apache.org/r/34082/#comment190912> Debug log as: ("Getting permissions for groups: {}, users: {}", groups, users); The same comment for several other instances. - Jerry Chen On April 6, 2016, 2:51 p.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34082/ > ----------------------------------------------------------- > > (Updated April 6, 2016, 2:51 p.m.) > > > Review request for sentry, Dapeng Sun and Jerry Chen. > > > Repository: sentry > > > Description > ------- > > Update policy engine for grant user to role > > > Diffs > ----- > > > sentry-policy/sentry-policy-common/src/main/java/org/apache/sentry/policy/common/PolicyEngine.java > bbb009c > > sentry-policy/sentry-policy-db/src/main/java/org/apache/sentry/policy/db/SimpleDBPolicyEngine.java > b5b584f > > sentry-policy/sentry-policy-indexer/src/main/java/org/apache/sentry/policy/indexer/SimpleIndexerPolicyEngine.java > 2f4bc1d > > sentry-policy/sentry-policy-kafka/src/main/java/org/apache/sentry/policy/kafka/SimpleKafkaPolicyEngine.java > 7e043e1 > > sentry-policy/sentry-policy-search/src/main/java/org/apache/sentry/policy/search/SimpleSearchPolicyEngine.java > bc518fb > > sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SimpleSqoopPolicyEngine.java > e8615a0 > > Diff: https://reviews.apache.org/r/34082/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
