-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47937/#review135336
-----------------------------------------------------------




sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtFunctionScope.java
 (line 118)
<https://reviews.apache.org/r/47937/#comment200362>

    Belive this is not necessary; If you put any resource file into resources 
dir with the same root as src, shouldn't call this fashion of absolute path.



sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtFunctionScope.java
 (line 119)
<https://reviews.apache.org/r/47937/#comment200364>

    Can you double check if sentry support add command? Seems we have 
blacklisted it for any user. Even if you grant permissions to user, he can't 
add resources. https://issues.apache.org/jira/browse/HIVE-5400



sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtFunctionScope.java
 (line 120)
<https://reviews.apache.org/r/47937/#comment200365>

    BTW, can you add myudfs.java then let compiler compiles it, once create 
myudfs.jar will be put into target dir; your test can have access from there. 
So no need to check in myudfs.jar. Not sure if your compiled version will work 
on different systems or not (jdk7, 8 etc.)


- Anne Yu


On May 27, 2016, 1:33 a.m., Ke Jia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47937/
> -----------------------------------------------------------
> 
> (Updated May 27, 2016, 1:33 a.m.)
> 
> 
> Review request for sentry, Anne Yu and Dapeng Sun.
> 
> 
> Bugs: SENTRY-1134
>     https://issues.apache.org/jira/browse/SENTRY-1134
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Add user defined UDF test, user create a jar then create udf from this jar.
> 
> 
> Diffs
> -----
> 
>   .gitignore 80d5c03 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtFunctionScope.java
>  ef7a86c 
>   sentry-tests/sentry-tests-hive/src/test/resources/myudfs.jar PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47937/diff/
> 
> 
> Testing
> -------
> 
> Testing
> 
> 
> Thanks,
> 
> Ke Jia
> 
>

Reply via email to