> On June 3, 2016, 7:43 a.m., Dapeng Sun wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtFunctionScope.java, > > line 116 > > <https://reviews.apache.org/r/47937/diff/2/?file=1401485#file1401485line116> > > > > Could we add a negative test before? for example, user2or3 can't create > > it.
Thanks dapeng for comment. I have added a negative case. - Ke ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47937/#review136048 ----------------------------------------------------------- On June 1, 2016, 2:09 a.m., Ke Jia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47937/ > ----------------------------------------------------------- > > (Updated June 1, 2016, 2:09 a.m.) > > > Review request for sentry, Anne Yu and Dapeng Sun. > > > Bugs: SENTRY-1134 > https://issues.apache.org/jira/browse/SENTRY-1134 > > > Repository: sentry > > > Description > ------- > > Add user defined UDF test, user create a jar then create udf from this jar. > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtFunctionScope.java > ef7a86c > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUDF.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/47937/diff/ > > > Testing > ------- > > Testing > > > Thanks, > > Ke Jia > >
