----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49428/#review140122 -----------------------------------------------------------
Thank Ke, I left some comments. sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java (line 218) <https://reviews.apache.org/r/49428/#comment205427> privHiveObj could be null, please also add some comments here. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java (line 751) <https://reviews.apache.org/r/49428/#comment205428> It seems we don't need the change if privHiveObj is null sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithGrantOption.java (line 338) <https://reviews.apache.org/r/49428/#comment205426> Please move the test to TestDatabaseProvider - Dapeng Sun On 六月 30, 2016, 4:02 p.m., Ke Jia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49428/ > ----------------------------------------------------------- > > (Updated 六月 30, 2016, 4:02 p.m.) > > > Review request for sentry and Dapeng Sun. > > > Bugs: SENTRY-1327 > https://issues.apache.org/jira/browse/SENTRY-1327 > > > Repository: sentry > > > Description > ------- > > Enable "show grant role roleName on all" command > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java > 25531af > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > 3de1f65 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithGrantOption.java > cfbef4a > > Diff: https://reviews.apache.org/r/49428/diff/ > > > Testing > ------- > > test done > > > Thanks, > > Ke Jia > >
