> On June 30, 2016, 8:37 a.m., Dapeng Sun wrote: > > Thank Ke, I left some comments.
Thanks dapeng comment. I fixed. - Ke ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49428/#review140122 ----------------------------------------------------------- On July 1, 2016, 2:25 a.m., Ke Jia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49428/ > ----------------------------------------------------------- > > (Updated July 1, 2016, 2:25 a.m.) > > > Review request for sentry and Dapeng Sun. > > > Bugs: SENTRY-1327 > https://issues.apache.org/jira/browse/SENTRY-1327 > > > Repository: sentry > > > Description > ------- > > Enable "show grant role roleName on all" command > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java > 25531af > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java > ff4eeaf > > Diff: https://reviews.apache.org/r/49428/diff/ > > > Testing > ------- > > test done > > > Thanks, > > Ke Jia > >