> On July 29, 2016, 6:26 p.m., Rahul Sharma wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestProgrammaticFailover.java, > > lines 117-120 > > <https://reviews.apache.org/r/50611/diff/1/?file=1457990#file1457990line117> > > > > how is the boolean return value from failover() useful?
Yeah, will validate this boolean value before move forward to validation. > On July 29, 2016, 6:26 p.m., Rahul Sharma wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java, > > line 36 > > <https://reviews.apache.org/r/50611/diff/1/?file=1457991#file1457991line36> > > > > Logger for this class? Good catch, will modify this to the current class. - Anne ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50611/#review144144 ----------------------------------------------------------- On July 29, 2016, 5:27 p.m., Anne Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50611/ > ----------------------------------------------------------- > > (Updated July 29, 2016, 5:27 p.m.) > > > Review request for sentry, Hao Hao and Sravya Tirukkovalur. > > > Bugs: SENTRY-1423 > https://issues.apache.org/jira/browse/SENTRY-1423 > > > Repository: sentry > > > Description > ------- > > Sentry HA Test: test programmatic failover, validate privileges before and > afterwards. validate expected exception is thrown. > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestProgrammaticFailover.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > 7dc3d0f30583b9edd16015218b199e298d192e8c > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/InternalSentrySrv.java > 054b1935975368db058791102f3892f027e31636 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/SentrySrv.java > dac11517f36a743dff8730465fbf2397ebf16c88 > > Diff: https://reviews.apache.org/r/50611/diff/ > > > Testing > ------- > > > Thanks, > > Anne Yu > >
