> On Aug. 17, 2016, 2:48 a.m., Dapeng Sun wrote: > > Thank Anne for your patch, I left some minor comments.
Thanks Dapeng. > On Aug. 17, 2016, 2:48 a.m., Dapeng Sun wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java, > > line 114 > > <https://reviews.apache.org/r/50611/diff/3/?file=1475619#file1475619line114> > > > > Nit: seem it is isActive's opposite, could we remove it to keep the > > code clean? Yeah, maybe just wrap around isActive. > On Aug. 17, 2016, 2:48 a.m., Dapeng Sun wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java, > > line 200 > > <https://reviews.apache.org/r/50611/diff/3/?file=1475619#file1475619line200> > > > > Nit: Just curious about why externalSentryService is related to > > Kerberos keytab file If the cluster is managed by an external software such as CDH, the keytab file is pre-installed, not managed by test. So from outside, we will need to pass keytab file location. One qq here, in mini-cluster testing environment (internal server), does it also use keytab and kerberos file? > On Aug. 17, 2016, 2:48 a.m., Dapeng Sun wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java, > > line 254 > > <https://reviews.apache.org/r/50611/diff/3/?file=1475619#file1475619line254> > > > > Nit: Better to add try catch block here. Will do so. - Anne ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50611/#review145951 ----------------------------------------------------------- On Aug. 16, 2016, 6:17 p.m., Anne Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50611/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2016, 6:17 p.m.) > > > Review request for sentry, Hao Hao and Sravya Tirukkovalur. > > > Bugs: SENTRY-1423 > https://issues.apache.org/jira/browse/SENTRY-1423 > > > Repository: sentry > > > Description > ------- > > Sentry HA Test: test programmatic failover, validate privileges before and > afterwards. validate expected exception is thrown. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientFactory.java > 56d774b883914dbffff438101f47fb94518c94d5 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestProgrammaticFailover.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > 7dc3d0f30583b9edd16015218b199e298d192e8c > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPolicyImportExport.java > 3f57a003903961a6aea98bd583a14b65bd2b98a2 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/InternalSentrySrv.java > 054b1935975368db058791102f3892f027e31636 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/SentrySrv.java > dac11517f36a743dff8730465fbf2397ebf16c88 > > Diff: https://reviews.apache.org/r/50611/diff/ > > > Testing > ------- > > > Thanks, > > Anne Yu > >
