----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53175/ -----------------------------------------------------------
Review request for sentry, Alexander Kolbasov, Anne Yu, Hao Hao, Lenni Kuff, and Sravya Tirukkovalur. Repository: sentry Description ------- Currently sentry clients e.g. impala uses non pool model (SentryPolicyServiceClientDefaultImpl), thus it's better to keep the non pool model for those clients to avoid unnecessary incompatible issues. Also the current pool model (PoolClientInvocationHandler) does not manage the opening connections very well. e.g. Opening connections with failed servers should be closed promptly. Diffs ----- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientFactory.java 9e90af8f5b638d346e3f48405441ad97b9ef09ad Diff: https://reviews.apache.org/r/53175/diff/ Testing ------- Thanks, Li Li
