----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53175/ -----------------------------------------------------------
(Updated Oct. 25, 2016, 10:25 p.m.) Review request for sentry, Alexander Kolbasov, Anne Yu, Hao Hao, Lenni Kuff, and Sravya Tirukkovalur. Repository: sentry Description ------- Currently sentry clients e.g. impala uses non pool model (SentryPolicyServiceClientDefaultImpl), thus it's better to keep the non pool model for those clients to avoid unnecessary incompatible issues. Also the current pool model (PoolClientInvocationHandler) does not manage the opening connections very well. e.g. Opening connections with failed servers should be closed promptly. Diffs (updated) ----- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/PoolClientInvocationHandler.java 842d5cafb06910fcbe6c53002f2101ec5b890a9e sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientFactory.java 9e90af8f5b638d346e3f48405441ad97b9ef09ad sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceFailureCase.java d1ac44766b049fb6fb6e6ce822cc0b63c0f6d66e Diff: https://reviews.apache.org/r/53175/diff/ Testing ------- Thanks, Li Li
