> On April 4, 2017, 4:33 p.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java > > Line 30 (original), 30 (patched) > > <https://reviews.apache.org/r/58164/diff/2/?file=1684326#file1684326line30> > > > > I don't think we need notification ID on PermChange table? Any reason > > to do otherwise?
I just tried to get the changes from Eddy's previous review. Just realized that they are not correct. Actual changes that are needed to MSentryPathChange.java and package.jdo are already committed. I will revert the changes done for MSentryPermChange.java and package.jdo. - kalyan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/#review170980 ----------------------------------------------------------- On April 6, 2017, 12:05 a.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58164/ > ----------------------------------------------------------- > > (Updated April 6, 2017, 12:05 a.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li. > > > Bugs: SENTRY-1638 > https://issues.apache.org/jira/browse/SENTRY-1638 > > > Repository: sentry > > > Description > ------- > > UpdateD SQL script of MSentryPathChange table to add a column for > notification ID. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql > 1829e2fa1f02a4339e7af4bf45a169013e9ec65f > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.derby.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.mysql.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.oracle.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.postgres.sql > PRE-CREATION > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql > 547bbe8136186658e7fe76ab24934157ea5300ff > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql > 6474389a18ea59da28d3d7125cf227c7aaa7f7aa > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql > 1ab83432db233ee4e7aa054adc1b82c26248a099 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql > 0418b298f7cbd8f430733cb329e9fca263bda0f7 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql > 68d2c8d53d7c468269ca2c41986ef8651b94f5c7 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql > 5376c166659b3e8e373c8c20818f5b1290af90c9 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql > dc3021a57ac9ea8145379c437ae6a94131c9ae5e > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql > ef1c651da8998eb57b5d0ca3463317d07c1b3a24 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql > f4a50de14dd0f961befaded394c6a01c2f459317 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql > db010bcd7792c9370478a2061e22d14bb78e3184 > > > Diff: https://reviews.apache.org/r/58164/diff/3/ > > > Testing > ------- > > > Thanks, > > kalyan kumar kalvagadda > >
