> On April 4, 2017, 4:40 p.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.oracle.sql > > Lines 1 (patched) > > <https://reviews.apache.org/r/58164/diff/2/?file=1684331#file1684331line1> > > > > Why create a new file for create notification id field inside > > PATHChange table? It should be ok to just add upon the > > 008-SENTRY-1569.xxx.sql as there is no release yet. > > kalyan kumar kalvagadda wrote: > My assumtion was that, we maintain one file per change which is labled > with the Jira id so that would have a track of every change and why. That way > we can use all thse files while upgrading. > > Thought, adding this change to 008-SENTRY-1569.xxx.sql would mix-up > things. > > Hao Hao wrote: > Ok, but I am not sure if there is any impact for upgrade by doing in this > way.
How about using the same file, but add comments to indicate the Jira case number? - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/#review170981 ----------------------------------------------------------- On April 6, 2017, 1:38 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58164/ > ----------------------------------------------------------- > > (Updated April 6, 2017, 1:38 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, and Na Li. > > > Bugs: SENTRY-1638 > https://issues.apache.org/jira/browse/SENTRY-1638 > > > Repository: sentry > > > Description > ------- > > UpdateD SQL script of MSentryPathChange table to add a column for > notification ID. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql > 1829e2fa1f02a4339e7af4bf45a169013e9ec65f > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql > 84b7903857ba51badde8a769eae86219eeaf3dab > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql > 69865508103bb8b1dd6148aa48c616d4b683614f > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql > 6a438ea847619af4d4d99d0fb99e036e55bf425f > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql > a9b7e2c48bb86bc0a81fad00d27387e26ef18c28 > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql > 547bbe8136186658e7fe76ab24934157ea5300ff > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql > 6474389a18ea59da28d3d7125cf227c7aaa7f7aa > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql > 1ab83432db233ee4e7aa054adc1b82c26248a099 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql > 0418b298f7cbd8f430733cb329e9fca263bda0f7 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql > 68d2c8d53d7c468269ca2c41986ef8651b94f5c7 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql > 5376c166659b3e8e373c8c20818f5b1290af90c9 > > > Diff: https://reviews.apache.org/r/58164/diff/6/ > > > Testing > ------- > > > Thanks, > > kalyan kumar kalvagadda > >
