----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/ -----------------------------------------------------------
(Updated April 12, 2017, 3:47 a.m.) Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar kalvagadda, and Sergio Pena. Changes ------- 1. Implement HMSFollower.close(). Remove its start() and stop(). 2. Add SentryService.close(), executor service shutdown are moved there. in stop(), cancel the future of the tasks instead of shutting down executor services. 3. In SentryService$CommandImpl.run(), call SentryService.stop() and close() instead of just call serviceExecutor.shutdown(). Repository: sentry Description ------- SENTRY-1649 move HMS follower to runServer Diffs (updated) ----- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java 6c14f5e sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java 132db63 Diff: https://reviews.apache.org/r/58221/diff/5/ Changes: https://reviews.apache.org/r/58221/diff/4-5/ Testing ------- Thanks, Na Li
