> On April 18, 2017, 9:41 p.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 314 (patched) > > <https://reviews.apache.org/r/58221/diff/15/?file=1693584#file1693584line346> > > > > Nit: this line seems too long. Similar to above ones longer than 100. > > Na Li wrote: > I will make it shorter. Sasha wants to mention that exception is > impossible to occure.
now the message is around 80. - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/#review172273 ----------------------------------------------------------- On April 19, 2017, 2:23 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58221/ > ----------------------------------------------------------- > > (Updated April 19, 2017, 2:23 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > SENTRY-1649 move HMS follower to runServer > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 16676fb > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 132db63 > > > Diff: https://reviews.apache.org/r/58221/diff/17/ > > > Testing > ------- > > > Thanks, > > Na Li > >
