> On April 19, 2017, 9:08 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 274 (patched) > > <https://reviews.apache.org/r/58221/diff/17/?file=1694265#file1694265line306> > > > > It seems that there is a valid use case for tests to call start() with > > diferent configurations to start new HMSFollower in start() method - this > > way, for example, tests may start it with different metastore URI. This > > contradicts my earlier comment, but I didn't know about this use case. > > > > So I would consider managing HMSFollower here as well. > > Na Li wrote: > will do.
HMSFollower is create in runServer() now. - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/#review172410 ----------------------------------------------------------- On April 25, 2017, 9:15 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58221/ > ----------------------------------------------------------- > > (Updated April 25, 2017, 9:15 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > SENTRY-1649 move HMS follower to runServer > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 57b7f88 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 132db63 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceUtil.java > ce73358 > > > Diff: https://reviews.apache.org/r/58221/diff/22/ > > > Testing > ------- > > > Thanks, > > Na Li > >
