-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58808/#review173252
-----------------------------------------------------------




sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql
Lines 30 (patched)
<https://reviews.apache.org/r/58808/#comment246295>

    Can you explain more about why using 'signleton'and why have '15' length 
restriction here? And add a comment to it.


- Hao Hao


On April 27, 2017, 6:19 p.m., kalyan kumar kalvagadda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58808/
> -----------------------------------------------------------
> 
> (Updated April 27, 2017, 6:19 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, 
> Vamsee Yarlagadda, and Vadim Spector.
> 
> 
> Bugs: SENTRY-1726
>     https://issues.apache.org/jira/browse/SENTRY-1726
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> 1. Created new table to store the last notification id
> 2. Table is defined to store only one entry.
> 
> 
> Diffs
> -----
> 
>   
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql
>  ba70715 
>   
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql
>  879e732 
>   
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql
>  e83ab83 
>   
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql
>  c28099b 
>   sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 
> 841dcaa 
>   
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 
> 223835e 
>   
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 
> 006d57b 
>   
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 
> 20921ea 
>   
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql
>  489ad66 
>   
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql
>  ec50912 
> 
> 
> Diff: https://reviews.apache.org/r/58808/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Reply via email to