> On April 27, 2017, 8:06 p.m., Vamsee Yarlagadda wrote: > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql > > Lines 24-34 (patched) > > <https://reviews.apache.org/r/58808/diff/1/?file=1702015#file1702015line24> > > > > Not sure what was the rule behind creating these patch files like > > SENTRY-1726.derby.sql for this change?
Convestion was to use the create new sql file for changes to db schema. There were comments from people when I tried similar convention with an argument, Why not bundle all the change done for HA into file file. I agree with them. Plan is to combine all the changes done for HA which are spread accross multiple sql file to one under SENTRY-872. So i did not mind creating new file for this change. Instead used the existing file. - kalyan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58808/#review173249 ----------------------------------------------------------- On April 27, 2017, 6:19 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58808/ > ----------------------------------------------------------- > > (Updated April 27, 2017, 6:19 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, > Vamsee Yarlagadda, and Vadim Spector. > > > Bugs: SENTRY-1726 > https://issues.apache.org/jira/browse/SENTRY-1726 > > > Repository: sentry > > > Description > ------- > > 1. Created new table to store the last notification id > 2. Table is defined to store only one entry. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql > ba70715 > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql > 879e732 > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql > e83ab83 > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql > c28099b > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql > 841dcaa > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql > 223835e > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql > 006d57b > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql > 20921ea > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql > 489ad66 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql > ec50912 > > > Diff: https://reviews.apache.org/r/58808/diff/1/ > > > Testing > ------- > > > Thanks, > > kalyan kumar kalvagadda > >
