----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58976/#review173965 -----------------------------------------------------------
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryClientTransportConfigInterface.java Lines 112 (patched) <https://reviews.apache.org/r/58976/#comment247055> I would suggest a better name for it. This setting, in effect, controls not the randomization but the load balancing between servers. So I'd suggest the name isLoadBalancingEnabled() and the corresponding config be named sentry.service.client.connection.loadbalance sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryClientTransportConstants.java Lines 103 (patched) <https://reviews.apache.org/r/58976/#comment247056> Naming - I would suggest the name SENTRY_CLIENT_LOAD_BALANCING sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryClientTransportConstants.java Lines 104 (patched) <https://reviews.apache.org/r/58976/#comment247057> Naming - I would suggest sentry.service.client.connection.loadbalance sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportFactory.java Lines 150 (patched) <https://reviews.apache.org/r/58976/#comment247058> We also want to check that the endpoints list has at least two elements. - Alexander Kolbasov On May 3, 2017, 9:29 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58976/ > ----------------------------------------------------------- > > (Updated May 3, 2017, 9:29 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, > Vamsee Yarlagadda, and Vadim Spector. > > > Bugs: SENTRY-1709 > https://issues.apache.org/jira/browse/SENTRY-1709 > > > Repository: sentry > > > Description > ------- > > Clients should randomize the server list based on the confguration. > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryClientTransportConfigInterface.java > 24192fd > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryClientTransportConstants.java > 4af7d1f > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryHDFSClientTransportConfig.java > 64cdd46 > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryPolicyClientTransportConfig.java > 396a7f6 > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportFactory.java > 9ddb400 > > > Diff: https://reviews.apache.org/r/58976/diff/1/ > > > Testing > ------- > > > Thanks, > > kalyan kumar kalvagadda > >
