> On May 4, 2017, 9:57 p.m., Alexander Kolbasov wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryClientTransportConfigInterface.java > > Lines 112 (patched) > > <https://reviews.apache.org/r/58976/diff/1/?file=1707311#file1707311line112> > > > > I would suggest a better name for it. This setting, in effect, controls > > not the randomization but the load balancing between servers. > > > > So I'd suggest the name > > > > isLoadBalancingEnabled() > > > > and the corresponding config be named > > > > sentry.service.client.connection.loadbalance
will fix > On May 4, 2017, 9:57 p.m., Alexander Kolbasov wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryClientTransportConstants.java > > Lines 103 (patched) > > <https://reviews.apache.org/r/58976/diff/1/?file=1707312#file1707312line103> > > > > Naming - I would suggest the name > > SENTRY_CLIENT_LOAD_BALANCING will fix > On May 4, 2017, 9:57 p.m., Alexander Kolbasov wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryClientTransportConstants.java > > Lines 104 (patched) > > <https://reviews.apache.org/r/58976/diff/1/?file=1707312#file1707312line104> > > > > Naming - I would suggest > > > > sentry.service.client.connection.loadbalance will fix > On May 4, 2017, 9:57 p.m., Alexander Kolbasov wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportFactory.java > > Lines 150 (patched) > > <https://reviews.apache.org/r/58976/diff/1/?file=1707315#file1707315line150> > > > > We also want to check that the endpoints list has at least two elements. will fix - kalyan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58976/#review173965 ----------------------------------------------------------- On May 3, 2017, 9:29 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58976/ > ----------------------------------------------------------- > > (Updated May 3, 2017, 9:29 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, > Vamsee Yarlagadda, and Vadim Spector. > > > Bugs: SENTRY-1709 > https://issues.apache.org/jira/browse/SENTRY-1709 > > > Repository: sentry > > > Description > ------- > > Clients should randomize the server list based on the confguration. > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryClientTransportConfigInterface.java > 24192fd > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryClientTransportConstants.java > 4af7d1f > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryHDFSClientTransportConfig.java > 64cdd46 > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryPolicyClientTransportConfig.java > 396a7f6 > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportFactory.java > 9ddb400 > > > Diff: https://reviews.apache.org/r/58976/diff/1/ > > > Testing > ------- > > > Thanks, > > kalyan kumar kalvagadda > >
