----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59031/#review174220 -----------------------------------------------------------
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java Lines 417 (patched) <https://reviews.apache.org/r/59031/#comment247335> Does this fix sentry-1750 "HMSFollower does not handle view update correctly" because such event won't be passed to HMSFollower? And there will be no notification event generated in TestHDFSIntegrationEnd2End.testViews? Does the barrier wait for such event, like creating view? If so, we should change berrier logic to not wait for such event. This change also means the notification ID is not continuous for HMSFollower. Will that cause issue? Can we have a unit test for this behavior? - Na Li On May 5, 2017, 9:38 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59031/ > ----------------------------------------------------------- > > (Updated May 5, 2017, 9:38 p.m.) > > > Review request for sentry. > > > Bugs: SENTRY-1714 > https://issues.apache.org/jira/browse/SENTRY-1714 > > > Repository: sentry > > > Description > ------- > > MetastorePlugin.java should quietly return from renameAuthzObject() when both > paths are null. At least one legitimate case when it happens is with the > views, which have no associated oldPath and newPath. > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java > fdb6df4 > > > Diff: https://reviews.apache.org/r/59031/diff/1/ > > > Testing > ------- > > Made sure that sentry metastore plugin is not invoked when view is renamed. > > > Thanks, > > kalyan kumar kalvagadda > >
