----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59031/#review174262 -----------------------------------------------------------
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java Lines 416 (patched) <https://reviews.apache.org/r/59031/#comment247397> What should happen of one of them is null - either old path or new path? - Alexander Kolbasov On May 5, 2017, 9:38 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59031/ > ----------------------------------------------------------- > > (Updated May 5, 2017, 9:38 p.m.) > > > Review request for sentry. > > > Bugs: SENTRY-1714 > https://issues.apache.org/jira/browse/SENTRY-1714 > > > Repository: sentry > > > Description > ------- > > MetastorePlugin.java should quietly return from renameAuthzObject() when both > paths are null. At least one legitimate case when it happens is with the > views, which have no associated oldPath and newPath. > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java > fdb6df4 > > > Diff: https://reviews.apache.org/r/59031/diff/1/ > > > Testing > ------- > > Made sure that sentry metastore plugin is not invoked when view is renamed. > > > Thanks, > > kalyan kumar kalvagadda > >
