-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59120/#review174499
-----------------------------------------------------------




sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
Lines 140 (patched)
<https://reviews.apache.org/r/59120/#comment247655>

    Fix the formatting.



sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
Lines 142 (patched)
<https://reviews.apache.org/r/59120/#comment247654>

    It does not help in debugging? If you don't see log message "Metastore uri 
is not configured in hive config. Returning", it is clear that you have some 
value in configured for "METASTOREURIS". Just that information may not help 
you. If you really want some log in possitive case, print the metastoreUri here 
instead of printing it below.


- kalyan kumar kalvagadda


On May 10, 2017, 3:37 p.m., Na Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59120/
> -----------------------------------------------------------
> 
> (Updated May 10, 2017, 3:37 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and 
> Sergio Pena.
> 
> 
> Bugs: sentry-1757
>     https://issues.apache.org/jira/browse/sentry-1757
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> use hive configuration to check.
> 
> 
> Diffs
> -----
> 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
>  e271ea4 
>   
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java
>  1530eb2 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java
>  32acc65 
> 
> 
> Diff: https://reviews.apache.org/r/59120/diff/2/
> 
> 
> Testing
> -------
> 
> integration test TestHDFSIntegrationEnd2End
> 
> 
> Thanks,
> 
> Na Li
> 
>

Reply via email to