> On May 10, 2017, 9:31 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 138 (patched) > > <https://reviews.apache.org/r/59120/diff/3/?file=1714167#file1714167line146> > > > > We have two cases here: > > > > 1) In production setup this is a fatal error (when HMS is configured) > > so this should be LOGGER.error() followed by an appropriate exception > > 2) In tests this is totally Ok but we do not want to print this every > > time run() is executed. > > > > Is there some way to distinguish between these two cases?
I think we can put all setup (such as saving configuration into hive-site.xml) before creating sentry server. In this way, production and testing will behave the same. And we don't need to differentiate them. - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59120/#review174565 ----------------------------------------------------------- On May 10, 2017, 6:44 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59120/ > ----------------------------------------------------------- > > (Updated May 10, 2017, 6:44 p.m.) > > > Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and > Sergio Pena. > > > Bugs: sentry-1757 > https://issues.apache.org/jira/browse/sentry-1757 > > > Repository: sentry > > > Description > ------- > > use hive configuration to check. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > e271ea4 > > sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java > 1530eb2 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java > 32acc65 > > > Diff: https://reviews.apache.org/r/59120/diff/3/ > > > Testing > ------- > > integration test TestHDFSIntegrationEnd2End > > > Thanks, > > Na Li > >
