----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58975/#review174579 -----------------------------------------------------------
There is a bunch of code in SentryStore that uses getLastProcessedChangeIDCore() - is it still needed or it is now obsolete? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/DeltaTransactionBlock.java Lines 91 (patched) <https://reviews.apache.org/r/58975/#comment247741> Where is the seqNum value set? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 3401 (patched) <https://reviews.apache.org/r/58975/#comment247740> use <p> separators sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 3406 (patched) <https://reviews.apache.org/r/58975/#comment247739> the code doesn't return null sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 3413 (patched) <https://reviews.apache.org/r/58975/#comment247738> Would it actually return null in this case? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java Line 95 (original), 100 (patched) <https://reviews.apache.org/r/58975/#comment247727> Why are you doing this in constructor? We need to make these decisions anyway when we call run() sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java Lines 105 (patched) <https://reviews.apache.org/r/58975/#comment247728> This is Ok for now, but we have a separate JIRA for fixing the conditio - it would make sense to add TODO comment here sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java Line 267 (original), 282 (patched) <https://reviews.apache.org/r/58975/#comment247736> This should be assigned from sentrystore like we do everywhere else - assigning this from event seems wrong sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java Lines 285 (patched) <https://reviews.apache.org/r/58975/#comment247731> We don't know that, but we know that something went wrong. We do neeed to read it every time because we do not keep in-memory state sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java Lines 555 (patched) <https://reviews.apache.org/r/58975/#comment247737> Can we handle this as a separate Catch statement instead? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java Lines 571 (patched) <https://reviews.apache.org/r/58975/#comment247735> In all other places we assign it from SentrySTore but here suddenly we assign it from the eventId which looks wrong. - Alexander Kolbasov On May 10, 2017, 9:45 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58975/ > ----------------------------------------------------------- > > (Updated May 10, 2017, 9:45 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, > Vamsee Yarlagadda, and Vadim Spector. > > > Bugs: SENTRY-1669 > https://issues.apache.org/jira/browse/SENTRY-1669 > > > Repository: sentry > > > Description > ------- > > Sentry should store Id's of all the notifications that it processed in a > seperate database. > HMSFollower before every run should get the last notification ID from this > persistent store. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryHmsNotification.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > 8fd5278 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/DeltaTransactionBlock.java > f590a52 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > ef67865 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > e271ea4 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > e7443eb > > > Diff: https://reviews.apache.org/r/58975/diff/6/ > > > Testing > ------- > > Sentry stores Id's of all the notifications that it processed in a seperate > database. > HMSFollower before every run gets the last notification ID from this > persistent store. > > > Thanks, > > kalyan kumar kalvagadda > >
