-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58975/#review174796
-----------------------------------------------------------




sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
Lines 328 (patched)
<https://reviews.apache.org/r/58975/#comment248018>

    do we still need this line to wake up waiting clients with same wakeup at 
line 225?


- Na Li


On May 11, 2017, 1:16 p.m., kalyan kumar kalvagadda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58975/
> -----------------------------------------------------------
> 
> (Updated May 11, 2017, 1:16 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, 
> Vamsee Yarlagadda, and Vadim Spector.
> 
> 
> Bugs: SENTRY-1669
>     https://issues.apache.org/jira/browse/SENTRY-1669
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Sentry should store Id's of all the notifications that it processed in a 
> seperate database.
> HMSFollower before every run should get the last notification ID from this 
> persistent store.
> 
> 
> Diffs
> -----
> 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryHmsNotification.java
>  PRE-CREATION 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo
>  8fd5278 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/DeltaTransactionBlock.java
>  f590a52 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
>  ef67865 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
>  9880c40 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
>  e7443eb 
> 
> 
> Diff: https://reviews.apache.org/r/58975/diff/8/
> 
> 
> Testing
> -------
> 
> Sentry stores Id's of all the notifications that it processed in a seperate 
> database.
> HMSFollower before every run gets the last notification ID from this 
> persistent store.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Reply via email to