> On May 10, 2017, 3:57 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/UpdatableCache.java > > Lines 207 (patched) > > <https://reviews.apache.org/r/59077/diff/1/?file=1711164#file1711164line207> > > > > do you meant to have "timer = null"?
No, I meant to reset savedTimer because we already closed the timer. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59077/#review174491 ----------------------------------------------------------- On May 9, 2017, 12:13 a.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59077/ > ----------------------------------------------------------- > > (Updated May 9, 2017, 12:13 a.m.) > > > Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Na Li, and > Vamsee Yarlagadda. > > > Bugs: SENTRY-1739 > https://issues.apache.org/jira/browse/SENTRY-1739 > > > Repository: sentry > > > Description > ------- > > SENTRY-1739 Sentry Kafka tests do not stop periodic update after the test end > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/SentryGenericProviderBackend.java > 134012d18d75d12e3ccce82dac8145bfc41609f5 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/UpdatableCache.java > f272630171763b8afa2cbd826cb2004532e52a4a > > sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/tests/e2e/kafka/AbstractKafkaSentryTestBase.java > 5807f68128258cbf187eb13c518218d0e3f553aa > > > Diff: https://reviews.apache.org/r/59077/diff/1/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
