> On May 9, 2017, 3:22 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/UpdatableCache.java > > Lines 39 (patched) > > <https://reviews.apache.org/r/59077/diff/1/?file=1711164#file1711164line39> > > > > Could several threads create their own UpdatableCache? If so, then > > "savedTimer = timer" will forget the previous timer. should it be a list > > instead? > > Alexander Kolbasov wrote: > That's not what users do - they have a single one
Then can we enforce there is only one instance? like singleton. > On May 9, 2017, 3:22 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/UpdatableCache.java > > Lines 143 (patched) > > <https://reviews.apache.org/r/59077/diff/1/?file=1711164#file1711164line143> > > > > When is "initialized" set to false? > > Alexander Kolbasov wrote: > That's the default initialization, but can make it explicit. > > Alexander Kolbasov wrote: > It is set to false when it is initialized > private boolean initialized = false; like start() and stop(), What's the counter part of initalize() that sets initialized = false? Should disable() or close() set it to false? - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59077/#review174318 ----------------------------------------------------------- On May 9, 2017, 12:13 a.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59077/ > ----------------------------------------------------------- > > (Updated May 9, 2017, 12:13 a.m.) > > > Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Na Li, and > Vamsee Yarlagadda. > > > Bugs: SENTRY-1739 > https://issues.apache.org/jira/browse/SENTRY-1739 > > > Repository: sentry > > > Description > ------- > > SENTRY-1739 Sentry Kafka tests do not stop periodic update after the test end > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/SentryGenericProviderBackend.java > 134012d18d75d12e3ccce82dac8145bfc41609f5 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/UpdatableCache.java > f272630171763b8afa2cbd826cb2004532e52a4a > > sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/tests/e2e/kafka/AbstractKafkaSentryTestBase.java > 5807f68128258cbf187eb13c518218d0e3f553aa > > > Diff: https://reviews.apache.org/r/59077/diff/1/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
