> On May 15, 2017, 4:21 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestConcurrentHMSFollowers.java > > Lines 92 (patched) > > <https://reviews.apache.org/r/59174/diff/2/?file=1716959#file1716959line92> > > > > Need a space between methods.
will fix. > On May 15, 2017, 4:21 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestConcurrentHMSFollowers.java > > Lines 102 (patched) > > <https://reviews.apache.org/r/59174/diff/2/?file=1716959#file1716959line102> > > > > Need a space between methods. will fix. > On May 15, 2017, 4:21 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestConcurrentHMSFollowers.java > > Lines 134-135 (patched) > > <https://reviews.apache.org/r/59174/diff/2/?file=1716959#file1716959line134> > > > > Are we testing the situation when two HMSFollower are processing > > notifications at the same time? Do we allow this situation? This is not a desirable situation but it is possible. There should situataions where both the nodes assume to be leader and act accordingly. They may not be in this state for a long time tough. - kalyan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59174/#review174959 ----------------------------------------------------------- On May 11, 2017, 12:51 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59174/ > ----------------------------------------------------------- > > (Updated May 11, 2017, 12:51 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, Hao Hao, Na Li, > Sergio Pena, Vamsee Yarlagadda, and Vadim Spector. > > > Bugs: SENTRY-1761 > https://issues.apache.org/jira/browse/SENTRY-1761 > > > Repository: sentry > > > Description > ------- > > Added test to make sure that SENTRY_HMS_NOTIFICATION_ID table is properly > updated even when multiple HMSFollowers are processing notifications from HMS. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestConcurrentHMSFollowers.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59174/diff/2/ > > > Testing > ------- > > > Thanks, > > kalyan kumar kalvagadda > >
