> On June 6, 2017, 12:07 a.m., Vamsee Yarlagadda wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestConcurrentHMSFollowers.java > > Lines 47 (patched) > > <https://reviews.apache.org/r/59174/diff/4/?file=1724141#file1724141line47> > > > > IS this really a concern anymore given there can be only one > > HMSFollower running?
There is no guarentee that there would be only one HMSFollower running. There could be certain time when both the sentry servers could be acting as leaders. - kalyan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59174/#review176968 ----------------------------------------------------------- On May 18, 2017, 7:16 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59174/ > ----------------------------------------------------------- > > (Updated May 18, 2017, 7:16 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, Hao Hao, Na Li, > Sergio Pena, Vamsee Yarlagadda, and Vadim Spector. > > > Bugs: SENTRY-1761 > https://issues.apache.org/jira/browse/SENTRY-1761 > > > Repository: sentry > > > Description > ------- > > Added test to make sure that SENTRY_HMS_NOTIFICATION_ID table is properly > updated even when multiple HMSFollowers are processing notifications from HMS. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestConcurrentHMSFollowers.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59174/diff/4/ > > > Testing > ------- > > > Thanks, > > kalyan kumar kalvagadda > >
