----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59317/#review175135 -----------------------------------------------------------
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportFactory.java Lines 77-79 (original) <https://reviews.apache.org/r/59317/#comment248508> I think it is not a good idea to remove this section. This patch handles it well for Generic clients but for HDFS and Policy client the behavior is unexpected. The reason why we are getting the right UGI for HDFS, Hive is that their codebases are doing some UGI related stuff before starting the Sentry client connection and that is why we are getting that context for free. And Hive, HDFS logic of setting UGI is not aware that a sentry client is depenedent on it. In future, if they restructure code it is very likely that they will break us and a more diffucult problem would be to debug this and fix it. So i would rather suggest the client do all the things (setting UGI) it needs so that these long chain of dependencies could be avoided. - Vamsee Yarlagadda On May 16, 2017, 6:21 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59317/ > ----------------------------------------------------------- > > (Updated May 16, 2017, 6:21 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, Hao Hao, Na Li, > Sergio Pena, Vamsee Yarlagadda, and Vadim Spector. > > > Bugs: SENTRY-1736 > https://issues.apache.org/jira/browse/SENTRY-1736 > > > Repository: sentry > > > Description > ------- > > As part of SENTRY-1593, code in SentryGenericServiceClientDefaultImpl which > set HADOOP_SECURITY_AUTHENTICATION property and update UserGroupInformation > class is missed. > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportFactory.java > 9b9f9e8 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClientDefaultImpl.java > b7ac640 > > > Diff: https://reviews.apache.org/r/59317/diff/1/ > > > Testing > ------- > > Made sure that Solr client is able to talk to sentry with kerberos enabled. > > > Thanks, > > kalyan kumar kalvagadda > >
