> On May 16, 2017, 6:41 p.m., Vamsee Yarlagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClientDefaultImpl.java > > Line 67 (original), 69 (patched) > > <https://reviews.apache.org/r/59317/diff/1/?file=1721745#file1721745line69> > > > > Why can't we change the supplied conf itself? That way if the clients > > (SentryShellSolr, SentryShellKafka) need to use their conf for something > > else, they will have all the updates. > > kalyan kumar kalvagadda wrote: > If there are not updating HADOOP_SECURITY_AUTHENTICATION how would > changing the supplied copy help. I'm not sure is there would any other issues > if we do so. > > If you are sure it doesn't create any issues, will update the patch.
What I am saying is as a client (SentrySehllSolr), they could be using that conf for other purposes too right? If they use the same conf everywhere they can get the advantage of changes being done to it. - Vamsee ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59317/#review175137 ----------------------------------------------------------- On May 16, 2017, 6:21 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59317/ > ----------------------------------------------------------- > > (Updated May 16, 2017, 6:21 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, Hao Hao, Na Li, > Sergio Pena, Vamsee Yarlagadda, and Vadim Spector. > > > Bugs: SENTRY-1736 > https://issues.apache.org/jira/browse/SENTRY-1736 > > > Repository: sentry > > > Description > ------- > > As part of SENTRY-1593, code in SentryGenericServiceClientDefaultImpl which > set HADOOP_SECURITY_AUTHENTICATION property and update UserGroupInformation > class is missed. > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportFactory.java > 9b9f9e8 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClientDefaultImpl.java > b7ac640 > > > Diff: https://reviews.apache.org/r/59317/diff/1/ > > > Testing > ------- > > Made sure that Solr client is able to talk to sentry with kerberos enabled. > > > Thanks, > > kalyan kumar kalvagadda > >
