> On May 18, 2017, 10:21 p.m., Vamsee Yarlagadda wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/UserGroupInformationInitializer.java > > Lines 43-45 (patched) > > <https://reviews.apache.org/r/59317/diff/3/?file=1724152#file1724152line43> > > > > We should only do this if conf contains any of the property > > sentry.service.security.mode or sentry.hdfs.service.security.mode is set > > to kerberos? > > kalyan kumar kalvagadda wrote: > All of that is implicitly checked. UgiSaslClientTransport in transport > factory will be called only when sentry.service.security.mode is kerberos and > sentry.service.security.use.ugi are enabled.
Oh yeah you are right. This is taken care of by transportFactory.isKerberosEnabled() check. - Vamsee ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59317/#review175440 ----------------------------------------------------------- On May 18, 2017, 10:35 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59317/ > ----------------------------------------------------------- > > (Updated May 18, 2017, 10:35 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, Hao Hao, Na Li, > Sergio Pena, Vamsee Yarlagadda, and Vadim Spector. > > > Bugs: SENTRY-1736 > https://issues.apache.org/jira/browse/SENTRY-1736 > > > Repository: sentry > > > Description > ------- > > 1. Update the UserGroupInformation with HADOOP_SECURITY_AUTHENTICATION for > the client when kerberos is enabled. > 2. Make sure that the update is not done for every connection towards sentry > server. > 3. Don't update the configuration object that we passed. Instead use a local > version to update. > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportFactory.java > 9b9f9e8 > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/UserGroupInformationInitializer.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClientDefaultImpl.java > b7ac640 > > > Diff: https://reviews.apache.org/r/59317/diff/4/ > > > Testing > ------- > > Made sure that Solr client is able to talk to sentry with kerberos enabled. > > > Thanks, > > kalyan kumar kalvagadda > >
