----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59810/#review176970 -----------------------------------------------------------
Should we do the exception juggling here when we create connection or in the retry client handler where we decide when to retry? sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportFactory.java Line 228 (original), 225 (patched) <https://reviews.apache.org/r/59810/#comment250513> What's wrong with the original message? Since you are changing this line, let's use logger formatting: LOGGER.error("Failed connection to Sentry server {}", addr); sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportFactory.java Lines 245 (patched) <https://reviews.apache.org/r/59810/#comment250514> Please add comment to this class explaining the non-trivial exception handling. sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportFactory.java Lines 250 (patched) <https://reviews.apache.org/r/59810/#comment250515> We don't need getMessge, can just use e as an argument sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportFactory.java Lines 269 (patched) <https://reviews.apache.org/r/59810/#comment250516> Move the declaration to the place where it is actually used. - Alexander Kolbasov On June 5, 2017, 7:25 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59810/ > ----------------------------------------------------------- > > (Updated June 5, 2017, 7:25 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, Hao Hao, Na Li, > Sergio Pena, Vamsee Yarlagadda, and Vadim Spector. > > > Bugs: SENTRY-1791 > https://issues.apache.org/jira/browse/SENTRY-1791 > > > Repository: sentry > > > Description > ------- > > Root case: > 1. Client was expecting TTransportException exception when there is failure > while opening TSaslClientTransport but it was throwing > UndeclaredThrowableException with cause asTTransportException. > 2. On failure with first server sentry client tried to connect to the second > sentry server with wrong principle. > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportFactory.java > 74aced2 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceFailureCase.java > 7c7ebab > > > Diff: https://reviews.apache.org/r/59810/diff/1/ > > > Testing > ------- > > Made sure that all the existing units passed. To test the exact fix we need > test framework to test with multiple sentry servers. I have an outstanding > code review with that changes. Once that changes are comitted we can add > tests for multiple sentry servres. > > > Thanks, > > kalyan kumar kalvagadda > >
