-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59810/
-----------------------------------------------------------
(Updated June 13, 2017, 11:41 p.m.)
Review request for sentry, Alexander Kolbasov, Brian Towles, Hao Hao, Na Li,
Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
Changes
-------
Based the patch with the recent commit made to have connection pool towards
sentry server.
Bugs: SENTRY-1791
https://issues.apache.org/jira/browse/SENTRY-1791
Repository: sentry
Description
-------
Root case:
1. Client was expecting TTransportException exception when there is failure
while opening TSaslClientTransport but it was throwing
UndeclaredThrowableException with cause asTTransportException.
2. On failure with first server sentry client tried to connect to the second
sentry server with wrong principle.
Diffs (updated)
-----
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/RetryClientInvocationHandler.java
62d0d2c
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportFactory.java
d299113
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/TransportFactory.java
e115cbb
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceFailureCase.java
7c7ebab
Diff: https://reviews.apache.org/r/59810/diff/3/
Changes: https://reviews.apache.org/r/59810/diff/2-3/
Testing
-------
Made sure that all the existing units passed. To test the exact fix we need
test framework to test with multiple sentry servers. I have an outstanding code
review with that changes. Once that changes are comitted we can add tests for
multiple sentry servres.
Thanks,
kalyan kumar kalvagadda
