> On June 7, 2017, 9:56 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUtil.java > > Lines 59 (patched) > > <https://reviews.apache.org/r/59869/diff/3/?file=1743642#file1743642line59> > > > > It seems that you need a different function - given list of ingerer > > IDs, return a string in the form > > "1-3, 5-7" > > > > Then the code can generate the list of IDs and call it. No one needs > > the list of lists thing. > > Vamsee Yarlagadda wrote: > Yes, collapseChangeIDsToString does exactly that. Given a collection of > changes, it first gets the list of lists (by calling groupChangesByIDs) and > then creates a string of the format [1-3, 5-7] etc.
What I mean is that you don't need the intermediate list of lists. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59869/#review177229 ----------------------------------------------------------- On June 7, 2017, 11:09 p.m., Vamsee Yarlagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59869/ > ----------------------------------------------------------- > > (Updated June 7, 2017, 11:09 p.m.) > > > Review request for sentry, Alexander Kolbasov and Lei Xu. > > > Repository: sentry > > > Description > ------- > > * Changes on top of Lina's review (https://reviews.apache.org/r/59820/) > * Adds a couple of helper methods that would go under MSentryUtil > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryChange.java > 6011ef407aaf82d211c81f6d6a55975fb21261b9 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUtil.java > 7558267546fc8c4dedc4f739df6092851becfc31 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 37eb0b25e10ef69057599277aa5941ca05d52290 > > > Diff: https://reviews.apache.org/r/59869/diff/4/ > > > Testing > ------- > > In progress. > > > Thanks, > > Vamsee Yarlagadda > >
