> On June 8, 2017, 5:16 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUtil.java > > Lines 139 (patched) > > <https://reviews.apache.org/r/59869/diff/5/?file=1744204#file1744204line139> > > > > Would the code produce such output? There is no joiner on commas. > > > > Also, the doc is incorrect, the output is not a list but a single > > string.
Yes, we are relying on the ArrayList.toString() which takes care of formatting in a similar way. The tests will show the behavior. > On June 8, 2017, 5:16 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUtil.java > > Lines 147 (patched) > > <https://reviews.apache.org/r/59869/diff/5/?file=1744204#file1744204line147> > > > > I think that's an overkill - it should be possible to do in a single > > pass over a list. Removed it completely > On June 8, 2017, 5:16 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUtil.java > > Lines 152 (patched) > > <https://reviews.apache.org/r/59869/diff/5/?file=1744204#file1744204line152> > > > > For two consequitive numbers (e.g. 5, 6) there is no value of writing > > 5-6, we only want to collapse for 3 or more. I understand what you mean. We can make it happen but we need to few more conditional checks and I don't see the much value of it. - Vamsee ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59869/#review177277 ----------------------------------------------------------- On June 8, 2017, 1:05 a.m., Vamsee Yarlagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59869/ > ----------------------------------------------------------- > > (Updated June 8, 2017, 1:05 a.m.) > > > Review request for sentry, Alexander Kolbasov and Lei Xu. > > > Repository: sentry > > > Description > ------- > > * Changes on top of Lina's review (https://reviews.apache.org/r/59820/) > * Adds a couple of helper methods that would go under MSentryUtil > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryChange.java > 6011ef407aaf82d211c81f6d6a55975fb21261b9 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUtil.java > 7558267546fc8c4dedc4f739df6092851becfc31 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 37eb0b25e10ef69057599277aa5941ca05d52290 > > > Diff: https://reviews.apache.org/r/59869/diff/5/ > > > Testing > ------- > > In progress. > > > Thanks, > > Vamsee Yarlagadda > >
