Hello,

What would people thing about enforcing code style for Apache Sentry code?
There is a maven/IntelliJ plugin - checkstyle (
http://checkstyle.sourceforge.net/index.html) that can help enforcing the
style.

The problem is that the current code isn't compliant and fails a lot of
checks and it wouldn't be reasonable to mass-modify a lot of existing code
to comply. Instead I would suggest that the new code and the code that is
modified extensively should comply and we can enforce this at code review
time. It might be interesting to research whether checkstyle tool can be
configured with a list of exclude/include files which can be modified as
more files are made compliant.

Another interesting issue is related to the style details. There are two
styles supported out of the box - original Sun Java style and Google style.
I am not sure what is the difference between the, it would be interesting
to research.

What do you think about this?

- Alex

Reply via email to