Interesting - I didn't know that I could configure IntelliJ to use the Google style and automatically format according to it. Will try.
On Mon, Jul 10, 2017 at 7:17 AM, Kalyan Kumar Kalvagadda < [email protected]> wrote: > Sasha, > > I have downloaded the google style xml file and added it to intellij. > > To change the existing code according to this style I should pick a file > and apply Code=>Format Code menu option. > > Is there something else I should be doing? > > -Kalyan > > On Fri, Jul 7, 2017 at 4:34 PM, Alexander Kolbasov <[email protected]> > wrote: > > > I was able to use Google style in IntelliJ - the trick is to set > checkstyle > > version to 7.1 and *apply* the change. After that you can point it to the > > google style xml file. > > > > Should we make this a requirement for new files? > > > > On Fri, Jul 7, 2017 at 6:06 PM, Sergio Pena <[email protected]> > > wrote: > > > > > I really like the google java style. Seems more updated to the > developing > > > practices these days. > > > > > > On Fri, Jul 7, 2017 at 10:55 AM, Alexander Kolbasov < > [email protected]> > > > wrote: > > > > > > > Thanks Lina. What is AD_SAL and MD_SAL? Who were you citing as the > > person > > > > preferring yo use Google Java style? Is there any description of the > > > > differences between the two? > > > > > > > > - Alex > > > > > > > > On Fri, Jul 7, 2017 at 5:51 PM, Na Li <[email protected]> wrote: > > > > > > > > > Sasha, > > > > > > > > > > found the following online, and I think we can go for google style. > > > > > > > > > > "Sun coding style was used in original contribution of Controller > and > > > > > AD-SAL and is mostly used in AD-SAL. > > > > > > > > > > Google Java Style is used in newer code such as YANGTools, MD-SAL, > > > etc... > > > > > so I would say prefer Google Java Style, since community decided on > > > going > > > > > with that style." > > > > > > > > > > I like the idea of enforcing style on new code. I can take a look > on > > > how > > > > > easy to do that. > > > > > > > > > > Thanks, > > > > > > > > > > Lina > > > > > > > > > > On Fri, Jul 7, 2017 at 9:50 AM, Alexander Kolbasov < > > [email protected] > > > > > > > > > wrote: > > > > > > > > > > > Hello, > > > > > > > > > > > > What would people thing about enforcing code style for Apache > > Sentry > > > > > code? > > > > > > There is a maven/IntelliJ plugin - checkstyle ( > > > > > > http://checkstyle.sourceforge.net/index.html) that can help > > > enforcing > > > > > the > > > > > > style. > > > > > > > > > > > > The problem is that the current code isn't compliant and fails a > > lot > > > of > > > > > > checks and it wouldn't be reasonable to mass-modify a lot of > > existing > > > > > code > > > > > > to comply. Instead I would suggest that the new code and the code > > > that > > > > is > > > > > > modified extensively should comply and we can enforce this at > code > > > > review > > > > > > time. It might be interesting to research whether checkstyle tool > > can > > > > be > > > > > > configured with a list of exclude/include files which can be > > modified > > > > as > > > > > > more files are made compliant. > > > > > > > > > > > > Another interesting issue is related to the style details. There > > are > > > > two > > > > > > styles supported out of the box - original Sun Java style and > > Google > > > > > style. > > > > > > I am not sure what is the difference between the, it would be > > > > interesting > > > > > > to research. > > > > > > > > > > > > What do you think about this? > > > > > > > > > > > > - Alex > > > > > > > > > > > > > > > > > > > > >
