----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60779/#review180240 -----------------------------------------------------------
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/FullUpdateInitializer.java Lines 95 (patched) <https://reviews.apache.org/r/60779/#comment255316> In SENTRY-1630 update, you move this class under thrift. If you want to be consistent with that change, how about naming this string as "HMS_FULL_UPDATE_INITIALIZER_THREAD_NAME" instead of "HDFS_FULL_UPDATE_INITIALIZER_THREAD_NAME" sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java Lines 158 (patched) <https://reviews.apache.org/r/60779/#comment255318> some place you call setDaemon(), and some place you don't. Do you know if the default value is false? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryKerberosContext.java Line 107 (original), 108 (patched) <https://reviews.apache.org/r/60779/#comment255317> why not use {} instead of "%s"? - Na Li On July 11, 2017, 6:55 p.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60779/ > ----------------------------------------------------------- > > (Updated July 11, 2017, 6:55 p.m.) > > > Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, > Sergio Pena, and Vamsee Yarlagadda. > > > Bugs: SENTRY-1798 > https://issues.apache.org/jira/browse/SENTRY-1798 > > > Repository: sentry > > > Description > ------- > > SENTRY-1798: Provide names for HMSFollower and cleaner threads > > This is an updated version of https://reviews.apache.org/r/60091/. > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/FullUpdateInitializer.java > cf9774c4fb5895df1fd3c26b9135ea5cad9344ef > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationInfo.java > 680db7a854c4313012a36c52ab167ca43503c299 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java > 0e5d6060faab5472b5f5c4e09b8029a3322481b4 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryKerberosContext.java > 8d78d1d4cadb1fa455a37bc8276793e9f231d691 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > ec938da1fb02bd0e58554336b671d14e7c6fc621 > > > Diff: https://reviews.apache.org/r/60779/diff/1/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
