----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60779/#review180312 -----------------------------------------------------------
LGTM otherwise sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryKerberosContext.java Line 148 (original), 148-150 (patched) <https://reviews.apache.org/r/60779/#comment255404> Should we do this at the constructor level? Otherwise we would end uo having duplicate thread names for multiple invocations of this method. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java Lines 83 (patched) <https://reviews.apache.org/r/60779/#comment255405> I see there is only one thread being started for this. What is the need to use %d then? - Vamsee Yarlagadda On July 12, 2017, 6:31 a.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60779/ > ----------------------------------------------------------- > > (Updated July 12, 2017, 6:31 a.m.) > > > Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, > Sergio Pena, and Vamsee Yarlagadda. > > > Bugs: SENTRY-1798 > https://issues.apache.org/jira/browse/SENTRY-1798 > > > Repository: sentry > > > Description > ------- > > SENTRY-1798: Provide names for HMSFollower and cleaner threads > > This is an updated version of https://reviews.apache.org/r/60091/. > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationInfo.java > 680db7a854c4313012a36c52ab167ca43503c299 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java > 0e5d6060faab5472b5f5c4e09b8029a3322481b4 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java > 1490581cc9bb882f4c14a180ade43aa4e8c18a82 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryKerberosContext.java > edb8006d95770a17ec4525be53887cb258bbe3e7 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 322197bd04754315d923563094bcade87510deec > > > Diff: https://reviews.apache.org/r/60779/diff/4/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
