Lina, Apache community is currently focused on sentry-ha to be released. It has highest priority over others. If you are contributing to that, I would say continue doing so.
-Kalyan On Wed, Jul 19, 2017 at 10:39 AM, Na Li <[email protected]> wrote: > Kalyan, > > I can work on those items. > > Can you create seperate Jiras for each one and add more info. > > In terms of priority, is finishing sentry-HA a higher priority than these > (for C6)? > > Thanks, > > Lina > > On Wed, Jul 19, 2017 at 10:02 AM, Kalyan Kumar Kalvagadda < > [email protected]> wrote: > > > Hello all, > > > > Either way we need to fix couple of things first. > > > > 1. Fix the test failures when hive-authz2 and datanucleus4 profiles are > > enabled. > > 2. Update e2e tests in sentry-tests-hive-v2 package to have same coverage > > as tests in sentry-tests-hive package. > > > > Does any one wants to take ownership of any of these tasks? > > > > > > -Kalyan > > > > On Tue, Jul 18, 2017 at 11:02 AM, Na Li <[email protected]> wrote: > > > > > I agree with Colm too. We can support Hive 2.1.1 only in sentry 2.0 > > > > > > Lina > > > > > > On Tue, Jul 18, 2017 at 10:03 AM, Sergio Pena < > [email protected]> > > > wrote: > > > > > > > I agree with Colm too. Hive 1.1 is too old and due to the way how > > Sentry > > > > works with HMS and notifications, it's not worth the effort to keep > > > > supporting Hive 1.1. Let's drop it. > > > > > > > > On Tue, Jul 18, 2017 at 8:47 AM, Colm O hEigeartaigh < > > > [email protected]> > > > > wrote: > > > > > > > > > I think we should drop support for Hive 1.1.0 in sentry 2.0.0. Hive > > > 1.1.0 > > > > > users can obtain the plugin from the Sentry 1.8.x series of > releases. > > > > > > > > > > Colm. > > > > > > > > > > On Tue, Jul 18, 2017 at 1:18 PM, Kalyan Kumar Kalvagadda < > > > > > [email protected]> wrote: > > > > > > > > > > > Hello all, > > > > > > > > > > > > Sentry currently supports Hive1.1.0 and Hive 2.0.0 based on the > > > profile > > > > > > used. I'm currently working on sentry 2.0.0 release upstream to > > > > integrate > > > > > > with Hive 2.1.1. > > > > > > > > > > > > I'm sending this mail seeking inputs on what is the support we > need > > > in > > > > > > Sentry 2.0.0 release. Would that be just Hive 2.x or both Hive > 2.x > > > and > > > > > Hive > > > > > > 1.1.0? > > > > > > > > > > > > I'm not sure if we should be supporting Hive 1.1.0 in sentry > 2.0.0. > > > As > > > > > Hive > > > > > > 1.1.0 is pretty old and the notification log implementation in > this > > > > > version > > > > > > which Sentry-HA is dependent on has a lot of bugs which are fixed > > in > > > > > later > > > > > > releases. Considering this, shouldn't we integrate sentry in > > release > > > > > 2.0.0 > > > > > > with Hive 2.1.1 and say that it would no more support older > > versions > > > > of > > > > > > Hive? > > > > > > > > > > > > > > > > > > Here are some of the approaches that we could take for Hive > > > integration > > > > > for > > > > > > sentry 2.0.0 release. > > > > > > > > > > > > *Approach-1:* Maintain support for both Hive 1.1.0 and Hive 2.1.1 > > > > > > *Approach-2: *Maintain support for both Hive 1.1.0 and Hive 2.1.1 > > for > > > > now > > > > > > and remove it by the time sentry 2.0.0 is released. > > > > > > *Approach-3:* Remove support for Hive 1.1.0 now. > > > > > > > > > > > > *Downside* for Approach 1 and 2 is that we need to put in lot of > > > effort > > > > > to > > > > > > have them work together as Hive 2.1.1 has a lot of API's changes > > > which > > > > > need > > > > > > changes to a lot classes in sentry-binding package but still > > maintain > > > > > > backward compatibility. > > > > > > If we want to take approach-1 for any reason, it's worth putting > > that > > > > > > effort otherwise we could take approach-3. > > > > > > > > > > > > > > > > > > My next steps would be based on what I hear form the community. > > > > > > > > > > > > -Kalyan > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > Colm O hEigeartaigh > > > > > > > > > > Talend Community Coder > > > > > http://coders.talend.com > > > > > > > > > > > > > > >
