----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61863/#review183764 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Line 1816 (original), 1816 (patched) <https://reviews.apache.org/r/61863/#comment259822> should the whole sql query section be moved to getRoleNamesForGroupsCore()? Usually, the function name ends with "Core" deals with query directly. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 1818 (patched) <https://reviews.apache.org/r/61863/#comment259819> this condition was checked at the beginning of this function. It won't happen here. - Na Li On Aug. 23, 2017, 9:24 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61863/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2017, 9:24 p.m.) > > > Review request for sentry, Alexander Kolbasov, Vamsee Yarlagadda, and Vadim > Spector. > > > Repository: sentry > > > Description > ------- > > Right now when we get privileges from sentry, we pass in a provider like set > of groups. Then we create a MSentryGroup object for each group and then get > roles using the .getRoles() method. However, DataNucleus takes too long and > the fetch doesn't seem to be lazy. This is bad since we only need the > roleNames for the group and not the entire Role object. > Instead running a SQL like query and just getting roleNames will drastically > improve performance > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > d7acaea7c > > > Diff: https://reviews.apache.org/r/61863/diff/1/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >
