----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61863/ -----------------------------------------------------------
(Updated Aug. 24, 2017, 7:26 p.m.) Review request for sentry, Alexander Kolbasov, Vamsee Yarlagadda, and Vadim Spector. Repository: sentry Description ------- Right now when we get privileges from sentry, we pass in a provider like set of groups. Then we create a MSentryGroup object for each group and then get roles using the .getRoles() method. However, DataNucleus takes too long and the fetch doesn't seem to be lazy. This is bad since we only need the roleNames for the group and not the entire Role object. Instead running a SQL like query and just getting roleNames will drastically improve performance Diffs (updated) ----- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java d7acaea7c Diff: https://reviews.apache.org/r/61863/diff/2/ Changes: https://reviews.apache.org/r/61863/diff/1-2/ Testing ------- Thanks, Arjun Mishra