----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61793/#review184946 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo Line 122 (original) <https://reviews.apache.org/r/61793/#comment261165> This change makes package.jdo inconsistent with sql scripts which do use these fields as keys and the goal was to make these consistent. - Alexander Kolbasov On Sept. 1, 2017, 9:53 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61793/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2017, 9:53 p.m.) > > > Review request for sentry, Alexander Kolbasov, Sergio Pena, and Vamsee > Yarlagadda. > > > Repository: sentry > > > Description > ------- > > reduce field size `SERVER_NAME`,`DB_NAME`,`TABLE_NAME`,`COLUMN_NAME` in > `SENTRY_DB_PRIVILEGE` from 4000 to 128, and remove `URI` from being part of > the unique id > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > 734ea7f > > > Diff: https://reviews.apache.org/r/61793/diff/4/ > > > Testing > ------- > > run datanucleus schema tool. Without this change, it complains > "com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Specified key was > too long; max key length is 767 bytes. > After those change, the datanucleus schema tool finishes successfully with > command "mvn datanucleus:schema-create -X -e" > > > Thanks, > > Na Li > >
