> On Sept. 7, 2017, 4:34 p.m., Sergio Pena wrote: > > The SQL files for derby and DB2 do have 4000 characters long on the fields > > you just modified. Should we change those as well? > > Na Li wrote: > I know that. Changing those will require changing sql files. Since they > are not causing any issue, I will update those sql files to make them > consistent in sentry-1914. > > Sergio Pena wrote: > I don't understand. Why we don't want to keep the consistency between > package.jdo and derby/db2 sql files? > Sentry-1914 is going to override these changes? > > Na Li wrote: > Yes. sentry-1914 is going to fix it once for all. Its change was part of > this code change for sentry-1894. but Sasha only wants me to change > package.jdo for this issue, and does not want me to change sql script. That > is why I created sentry-1914, and move those sql script changes to > sentry-1914. > > Now, you want me to move those sql to this issue. What should I do?
Right now, my goal is just to get this issue resolved, and get sentry-1914 resolve later. - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61793/#review184838 ----------------------------------------------------------- On Sept. 1, 2017, 9:53 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61793/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2017, 9:53 p.m.) > > > Review request for sentry, Alexander Kolbasov, Sergio Pena, and Vamsee > Yarlagadda. > > > Repository: sentry > > > Description > ------- > > reduce field size `SERVER_NAME`,`DB_NAME`,`TABLE_NAME`,`COLUMN_NAME` in > `SENTRY_DB_PRIVILEGE` from 4000 to 128, and remove `URI` from being part of > the unique id > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > 734ea7f > > > Diff: https://reviews.apache.org/r/61793/diff/4/ > > > Testing > ------- > > run datanucleus schema tool. Without this change, it complains > "com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Specified key was > too long; max key length is 767 bytes. > After those change, the datanucleus schema tool finishes successfully with > command "mvn datanucleus:schema-create -X -e" > > > Thanks, > > Na Li > >
